Generate Foreign Dex Entries #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added foreign languages to res/pokemon/<species>/data/json pokedex_data Removed prebuilt pokedex gmm files Renamed message banks 698-723
|
TEXT_BANK_DEX_ENTRY_UNUSED is technically referenced in pokedex_text.c, but if I am reading it correctly it should not actually get used. Data wise it is identical to TEXT_BANK_DEX_ENTRY_DIAMOND |
lhearachel
requested changes
Feb 2, 2025
Changed languages to ISO-639 codes Gave forms pokedex data fields moved name to pokedex data pokedex_text_banks -> species_text_banks
h2o-DS
commented
Feb 3, 2025
| @@ -70,21 +70,17 @@ def DataSize(num): | |||
|
|
|||
| for i, species_dir in enumerate(SPECIES_DIRS): | |||
| file = source_dir / species_dir / 'data.json' | |||
| if ((species_dir == 'giratina') and (args.giratina_form == 'giratina_origin')): | |||
| file = source_dir / 'giratina/forms/origin/data.json' | |||
There was a problem hiding this comment.
This is now the only Giratina weirdness
lhearachel
approved these changes
Feb 3, 2025
Co-authored-by: Rachel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added foreign languages to res/pokemon/species/data.json pokedex_data
Removed prebuilt pokedex gmm files
Renamed message banks 698-723