Document BDHC file loading #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhearachel
reviewed
Feb 5, 2025
src/overlay005/bdhc_loader.c
Outdated
| BDHCLoader_LoadAccessList(narc, bdhc, bdhcHeader); | ||
|
|
||
| Heap_FreeToHeap(bdhcHeader); | ||
| bdhc->loaded = 1; |
There was a problem hiding this comment.
polish: Use BOOL constants for this member, even if the underlying field is not a BOOL, just for the semantics.
src/overlay005/bdhc_loader.c
Outdated
| ctx->bdhc->stripsSize = ctx->bdhcHeader.stripsSize; | ||
| BDHCLoader_PrepareBuffers(&ctx->bdhcHeader, ctx->bdhc, (void **)&ctx->buffer); | ||
|
|
||
| subTaskCompleted = 1; |
There was a problem hiding this comment.
polish: Use TRUE/FALSE.
This documents the loading of BDHC files that are embedded in files of the land data NARC. Credits goes to Mikelan98, HiroTDK and HumanGamer for their resources (listed below). It would have been a lot more painful having to reverse this file format. Resources used: * https://hirotdk.neocities.org/FileSpecs#Terrain * https://www.pokecommunity.com/threads/i-solved-the-final-piece-of-the-terrain-bdhc-files-in-gen-4-inclines.424428/ Signed-off-by: Kuruyia <[email protected]>
Kuruyia
force-pushed
the
feat/document-bdhc-loading
branch
from
7517bc7 to
3f83011
Compare
|
Oopsie, looks like I got carried away while cleaning up the consts |
lhearachel
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the loading of BDHC files that are embedded in files of the land data NARC.
Credits goes to Mikelan98, HiroTDK and HumanGamer for their resources (listed below). It would have been a lot more painful having to reverse this file format.
Resources used: