Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document BDHC util #363

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

Kuruyia
Copy link
Contributor

@Kuruyia Kuruyia commented Feb 6, 2025

This documents the bdhc_util.c file, which mainly contains the function used to calculated an object's height based on its 2D position and the BDHC of the map its currently on.

@Kuruyia
Copy link
Contributor Author

Kuruyia commented Feb 6, 2025

Still not sure about the objectY naming convention. I like the consistency with objectX/objectZ, but objectHeight might be more understandable.

include/overlay005/bdhc_util.h Outdated Show resolved Hide resolved
include/overlay005/bdhc_util.h Outdated Show resolved Hide resolved
src/overlay005/bdhc_util.c Outdated Show resolved Hide resolved
@Kuruyia Kuruyia force-pushed the feat/document-bdhc-util branch from 8d76e3c to fd20265 Compare February 7, 2025 21:22
include/overlay005/bdhc.h Outdated Show resolved Hide resolved
include/overlay005/bdhc.h Outdated Show resolved Hide resolved
@Kuruyia Kuruyia force-pushed the feat/document-bdhc-util branch from fd20265 to 552149e Compare February 7, 2025 23:51
This documents the `bdhc_util.c` file, which mainly contains the
function used to calculated an object's height based on its 2D position
and the BDHC of the map its currently on.

Signed-off-by: Kuruyia <[email protected]>
@Kuruyia Kuruyia force-pushed the feat/document-bdhc-util branch from 552149e to caa281e Compare February 8, 2025 20:19
@lhearachel lhearachel enabled auto-merge February 8, 2025 20:21
@lhearachel lhearachel merged commit d88cd7f into pret:main Feb 8, 2025
2 checks passed
@Kuruyia Kuruyia deleted the feat/document-bdhc-util branch February 8, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants