Document map 3D objects #368
Conversation
|
Still not sure about the Also, maybe |
Didn't know about that, makes sense. Then let's go with Note: it may make less sense for non-building objects such as the honey tree you mentioned in another comment |
Kuruyia
force-pushed
the
feat/document-map-objects
branch
from
0e45deb to
8f7479e
Compare
I think that this is a fine trade-off. In the context of mapping, it's easier to refer to them as |
| NNS_G3dRenderObjInit(renderObj, *resMdl); | ||
| } | ||
|
|
||
| static void ov5_021E1944(const NNSG3dResMdl *resMdl, VecFx32 *position, MtxFx33 *rotation, VecFx32 *scale, const UnkStruct_ov5_021D5778 *param4, const int param5) |
There was a problem hiding this comment.
question: What are we missing to know how to document this function?
There was a problem hiding this comment.
We'll probably want to document the ov5_021D56BC.c file as this is the one in which UnkStruct_ov5_021D5778, ov5_021D579C() and ov5_021D57B4() are defined. Looks like it may be a pretty quick one to document.
Also, if you have an idea of what NNS_G3dDraw1Mat1Shp() does, that would help me. Looking at the function name and definition wasn't really helpful. Something about material and shape?
There was a problem hiding this comment.
Also, if you have an idea of what
NNS_G3dDraw1Mat1Shp()does, that would help me. Looking at the function name and definition wasn't really helpful. Something about material and shape?
Yep, that's my reading on it: sends the requested material and shape to VRAM for rendering.
This mainly documents the `ov5_021E15F4.c` file, which is in charge of reading 3D map objects from the land data NARC, managing them, and rendering them. A "3D map object" is defined here as a 3D model that is separate from the map 3D model, and that can be positioned, rotated, and scaled independently. For instance, they are usually used to place buildings on the various maps. Signed-off-by: Kuruyia <[email protected]>
Kuruyia
force-pushed
the
feat/document-map-objects
branch
from
8f7479e to
605397b
Compare
|
Coming back to this, per discussion on Discord, let's walk back on using the binary terminology and generalize the name to something like |
This mainly documents the
ov5_021E15F4.cfile, which is in charge of reading 3D map objects from the land data NARC, managing them, and rendering them.A "3D map object" is defined here as a 3D model that is separate from the map 3D model, and that can be positioned, rotated, and scaled independently. For instance, they are usually used to place buildings on the various maps.