-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Changelog #457
Update Changelog #457
Conversation
@Shinigami92 LGTM! |
Thx that's valuable to me, but I still need the ✔️-Approval also from @fisker, because he is one of the Prettier Core Maintainer |
@lehni @fisker https://www.npmjs.com/package/@prettier/plugin-pug/v/2.5.2 is released Not sure if I found today time anymore to start working on the ESM rewrite Just give me some time and you don't need to work so much yourself on the PRs, because at the end I need to merge it anyways ^^ |
@Shinigami92 I don't think the ESM conversion is technically needed right away to make the plugin work with prettier v3. I tested #456 with |
It is less a "need" but more a "like" Aside that, ESM is the future and some day I would need to do this step anyway, so why not now 🙂 |
I'm not arguing against ESM, absolutely embracing it myself in my projects. I'm just saying there's a viable quick path forward to making this plugin work with prettier v3, which would maybe remove some of the stresses of having to do the ESM transition at the same time. |
@lehni |
@lehni @fisker Please confirm that this Changelog is correct and I will release a v2.5.2
You can also see here 2.5.1...main what I changed since v2.5.1