Skip to content

Commit

Permalink
fix : 빌드 에러 수정 (#318)
Browse files Browse the repository at this point in the history
* fix : build 오류 해결

* env : build 검증훅 추가

* ci : 브랜치 변경

* ci : 빌드 체크 워크플로 수정
  • Loading branch information
HelloWook authored Dec 7, 2024
1 parent 9371bb6 commit 06ba208
Show file tree
Hide file tree
Showing 7 changed files with 36 additions and 73 deletions.
28 changes: 28 additions & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: PR Build Check

on:
pull_request:
branches:
- develope

jobs:
build:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Install dependencies
run: yarn install

- name: Run Build
run: yarn build

- name: Comment on PR
uses: thollander/actions-comment-pull-request@v1
if: success() && github.event_name == 'pull_request'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
message: '✅ Build 성공!'
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export const KeywordLetterDetail = ({
return <div>오류...: {keywordReplyListDataError.message}</div>;
}


return (
<div className={clsx(font ? font : 'font-sans')}>
<Margin top={20} />
Expand All @@ -67,7 +66,7 @@ export const KeywordLetterDetail = ({
</div>

{keywordReplyListData?.content ? (
<div className="mt-16 mx-auto">
<div className="mx-auto mt-16">
<ReplyList
keywordReplyListData={keywordReplyListData.content}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ type MapLetterDetailProps = {
};

export const MapLetterArchieveDetail = ({
letterData,
letterId
letterData
}: MapLetterDetailProps) => {
const { title, content, createdAt, font, description, profileImg } =
letterData;
Expand All @@ -31,7 +30,7 @@ export const MapLetterArchieveDetail = ({
<Margin top={20} />
<div className="relative z-20 flex flex-col justify-center w-9/12 m-auto py-9">
<div className="absolute top-0 right-0">
<DeleteButton id={String(letterId)} />
<DeleteButton />
</div>
<img
src={profileImg}
Expand Down
63 changes: 0 additions & 63 deletions src/components/LetterDetailPage/ReplyList/ReplyList.stories.tsx

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ export const LetterInfoContainer = ({
<img src="/bottle.png" alt="Bottle" className="w-20 h-20" />
</div>
<div className="flex flex-col h-20">
<div className="flex-center gap-2">
<div className="gap-2 flex-center">
<p className="text-sm text-gray-600">작성일: {date}</p>
<DayCounter width="40px" daysLeft={daysLeft} />
<DayCounter width="40px" createdAt={String(daysLeft)} />
</div>

<h3 className="text-lg font-semibold">{title}</h3>
Expand Down
4 changes: 2 additions & 2 deletions src/components/MapPage/Maplibre/Maplibre.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ export const Maplibre = () => {
latitude={letter.latitude}
>
<div
className="bg-gray-100 p-1 rounded-sm"
className="p-1 bg-gray-100 rounded-sm"
onClick={(e) => {
e.stopPropagation();
toggleSelectedLetter(letter);
//toggleSelectedLetter(letter);
}}
>
<img
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Letter/Detail/ReplyLetterDetailPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const ReplyLetterDetailPage = () => {
</div>
{replyLetterId && (
<div className="absolute top-0 flex mt-10 right-8">
<DeleteButton id={replyLetterId} />
<DeleteButton />
<ReportButton id={replyLetterId} />
</div>
)}
Expand Down

0 comments on commit 06ba208

Please sign in to comment.