Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HelloWook
requested review from
kangminguu,
cmlim0070,
mmjjaa and
saseungmin
as code owners
Closed
1 task
mmjjaa
approved these changes
Dec 6, 2024
cmlim0070
approved these changes
Dec 6, 2024
saseungmin
approved these changes
Dec 6, 2024
| className="object-cover rounded" | ||
| src={getImagePath(item.id)} | ||
| className="object-cover min-w-full rounded min-h-[120px]" | ||
| src={getImagePath(item.src!)} |
There was a problem hiding this comment.
!연산자를 사용하시는군요! 요 연산자는 TypeScript에게 "이 값이 확실히 null이나 undefined가 아니다"라고 알려주는 역할을 합니다~ 강제로 알려주는거죠!
let name: string | null = "Kim";
let nameLength = name.length; // 에러: 'name'이 null일 수 있습니다
let definiteLength = name!.length; // 성공: 개발자가 name이 null이 아님을 보장! 사용은 일반적으로 권장되지 않는 방법인데요!. 그 이유는 결국 런타임 에러의 위험이 있어요~ 위 예시처럼 만약 실제로 값이 null이면 에러 발생하기 때문이죠 결과적으로 TypeScript의 타입 안전성을 우회하는 것이기 때문이에요!
더 명확하게 이렇게 조건문을 사용한다거나 명시적으로 사용하는게 더 좋습니다!
if (item.src) {
getImagePath(item.src);
}
// 그럼에도 진짜 null이거나 undefined여도 상관없는경우
getImagePath(item?.src);| className="w-full m-auto overflow-hidden bg-transparent border-none resize-none min-h-[413px] min-w-[281px]" | ||
| className={`w-full m-auto overflow-hidden bg-transparent border-none resize-none min-h-[413px] min-w-[281px] ${font ? font : 'font-sans'}`} |
There was a problem hiding this comment.
조건문으로 스타일을 적용할때 string이기때문에 불편한점이 있죠! 생산성이 떨어질수밖에없는데,
https://xionwcfm.tistory.com/328
위 방법은 세가지의 라이브러리를 합쳐서 사용하는건데 간단하게
clsx 라이브러리의 도움을 받으면 더 간단하게 사용할 수 있습니다!
className={clsx(
`w-full m-auto overflow-hidden bg-transparent border-none resize-none min-h-[413px] min-w-[281px]`,
font ? font : 'font-sans'
)}
kangminguu
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀요약
📸사진 (구현 캡처)
📝작업 내용
🎸기타 (연관 이슈)
close #241