Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
훅의 역활이 편지 저장인만큼 더욱 적합한 네이밍으로 변경
의미상 Form이 더 잘맞을것 같아 변경했습니다.
HelloWook
requested review from
kangminguu,
cmlim0070,
mmjjaa and
saseungmin
as code owners
|
✅ Build 성공! |
⚡️ Lighthouse Report (Average of 5 runs)
Core Web Vitals (Average)
|
cmlim0070
reviewed
Dec 28, 2024
| import React from 'react'; | ||
| import { LetterInput } from '../LetterInput/LetterInput'; | ||
|
|
||
| type LettetProps = { |
There was a problem hiding this comment.
p4: LetterProps인데 오타가 난 것 같아요...!
웹 접근성 향상을 위한 aria-lable 작성
cmlim0070
approved these changes
Dec 29, 2024
img를 통해 불러오던 방식 -> 편지줄 컴포넌트를 이용해 불러오도록 변경
변경된 타입에 맞춰 스토리 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀요약
📝작업 내용
🔍 전달 사항
상세 페이지도 리펙토링이 필요하다 생각되는데 이 부분은 나중에 상의가 조금 필요할듯 싶습니다.
🎸기타 (연관 이슈)
close #8