Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Test Results82 tests 82 ✅ 17s ⏱️ Results for commit 7a05aec. ♻️ This comment has been updated with latest results. |
AnTaeho
reviewed
Jan 3, 2025
Comment on lines
143
to
145
| redisKeys = redisKeys.stream() | ||
| .filter(redisKey -> !redisKey.contains("_user")) | ||
| .filter(redisKey -> !redisKey.contains("_user") && !redisKey.contains("_targets")) | ||
| .collect(Collectors.toSet()); |
There was a problem hiding this comment.
나도 성능 체크를 해보긴 해야하는데
contains 보다 userTargetKey.split("_")[2].equals("targets");
이런식으로 구현하면 더 좋지 않을까 싶긴 함
| } | ||
|
|
||
| /** | ||
| * 한식간 마다 로컬 캐시에 있는 가중치를 꺼내어 Zset에 반영 | ||
| * 매 10분마다 가중치 반영 |
There was a problem hiding this comment.
전체적으로 시간 단위가 통일되어 있지 않은 느낌이 있음.
이전 PR에서도 어떤건 6시간 3시간 적혀있고, 12시간 마다 동작하는거도 있고 등등 한번 정리가 필요할듯
|
Leehunil
approved these changes
Jan 7, 2025
| @@ -187,12 +184,49 @@ public CustomSliceResponse findLikeList( | |||
| return gatheringRepository.PageFindLikeGathering(pageable, userId, likeId); | |||
| } | |||
|
|
|||
| public List<GatheringPopularResponse> gatheringPopular(Optional<User> user){ | |||
| String zSetKey = "gathering_Ranking"; | |||
There was a problem hiding this comment.
Const 이용해서 전역 변수로 처리하면 좋을 것 같아요!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
자세한 내용: https://velog.io/@kcsc2217/%EC%8B%A4%EC%8B%9C%EA%B0%84-%EC%9D%B8%EA%B8%B0-%ED%8F%AC%ED%8A%B8%ED%8F%B4%EB%A6%AC%EC%98%A4
스크린샷 (선택)
💬리뷰 요구사항(선택)