Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 게더링 디테일 페이지 구현 #69

Merged
merged 18 commits into from
Dec 1, 2024
Merged

Conversation

joarthvr
Copy link
Collaborator

@joarthvr joarthvr commented Nov 30, 2024

📌 관련 이슈


💭 작업 내용

  1. 게더링 디테일 페이지 레이아웃 구현
  2. 게더링 디테일 페이지에서 사용되는 컴포넌트 작성
  • 유저정보
  • 옵션 아이템
  1. 게더링 디테일 페이지에서 사용되는 위젯 구현
  • 디테일 페이지 헤더
  • 디테일 페이지 옵션 그리드

🤔 참고 사항

  • 백엔드 배포 후 스타일 정리 및 훅 리팩토링
  • 게더링 리스트 -> 게더링 그리드 -> 게더링 카드로 이어지게 수정해서 게더링 그리드에서 props 받도록 수정
  • 게더링 카드 컴포넌트 props 변경으로 유저페이지와 검색페이지 게더링 카드 참조하는 부분에서 수정

📸 스크린샷

image

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for palettee22 ready!

Name Link
🔨 Latest commit 6cd8422
🔍 Latest deploy log https://app.netlify.com/sites/palettee22/deploys/674c5766ce500e0008dc876b
😎 Deploy Preview https://deploy-preview-69--palettee22.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joarthvr joarthvr self-assigned this Nov 30, 2024
@joarthvr joarthvr added 🎨 Html&css 마크업 & 스타일링 ✨ Feature 기능 개발 labels Nov 30, 2024
Copy link

github-actions bot commented Dec 1, 2024

⚡ Lighthouse report for http://localhost:3000/

Category Score
🔴 Performance 38
🟢 Accessibility 95
🟢 Best Practices 100
🟠 SEO 83

Detailed Metrics

Metric Value
🔴 First Contentful Paint 41.5 s
🔴 Largest Contentful Paint 70.3 s
🟠 Total Blocking Time 310 ms
🟢 Cumulative Layout Shift 0
🔴 Speed Index 53.7 s

Copy link
Collaborator

@csk6314 csk6314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!


export const useGatheringDetail = (gatheringId: string) => {
const { data, isLoading, isError, error } = useQuery<GatheringDetailResponse, Error>({
queryKey: ['gathering', 'detail', gatheringId],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 쿼리키 통일하는게 좋을듯?
지금 아카이브는 "/archive" 이렇게 해놨고 게더링은 "gathering"으로 되어있어서
한쪽으로 통일하는게 좋아보여
그리고 어떤식으로 쿼리키 구성할지 나중에 얘기하면 좋을듯

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 수정하겠습니다!

@joarthvr joarthvr merged commit 30a3fec into dev Dec 1, 2024
1 check passed
Copy link

github-actions bot commented Dec 1, 2024

⚡ Lighthouse report for http://localhost:3000/

Category Score
🔴 Performance 26
🟢 Accessibility 95
🟢 Best Practices 100
🟠 SEO 83

Detailed Metrics

Metric Value
🔴 First Contentful Paint 45.4 s
🔴 Largest Contentful Paint 74.9 s
🔴 Total Blocking Time 760 ms
🟢 Cumulative Layout Shift 0
🔴 Speed Index 59.4 s

@joarthvr joarthvr deleted the 51-feat-gathering-detail branch December 1, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 🎨 Html&css 마크업 & 스타일링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants