Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 채팅 모달 및 채팅 버튼 ui 구현 #71

Merged
merged 6 commits into from
Dec 1, 2024

Conversation

joarthvr
Copy link
Collaborator

@joarthvr joarthvr commented Dec 1, 2024

📌 관련 이슈


💭 작업 내용

  1. 그라데이션 변수 등록
  2. 채팅 버튼 컴포넌트
  3. 채팅 레이아웃 컴포넌트
  4. 채팅 모달 등록

🤔 참고 사항

  • 회고에 pr 잘라서 하라는 피드백을 반영해 한번 자르고 가겠습니다 ㅎㅎ

📸 스크린샷

image

@joarthvr joarthvr self-assigned this Dec 1, 2024
@joarthvr joarthvr added 🎨 Html&css 마크업 & 스타일링 ✨ Feature 기능 개발 labels Dec 1, 2024
Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for palettee22 ready!

Name Link
🔨 Latest commit baa81be
🔍 Latest deploy log https://app.netlify.com/sites/palettee22/deploys/674c5830eb085c000823f957
😎 Deploy Preview https://deploy-preview-71--palettee22.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 1, 2024

⚡ Lighthouse report for http://localhost:3000/

Category Score
🔴 Performance 27
🟢 Accessibility 97
🟢 Best Practices 92
🟠 SEO 83

Detailed Metrics

Metric Value
🔴 First Contentful Paint 40.6 s
🔴 Largest Contentful Paint 69.1 s
🔴 Total Blocking Time 720 ms
🟢 Cumulative Layout Shift 0
🔴 Speed Index 53.1 s

Copy link
Collaborator

@csk6314 csk6314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조금 더 길게 PR 끊어도 괜찮을 것 같음!
스타일 코드만 긴거라

Copy link
Collaborator

@he2e2 he2e2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

채팅 탭에 알림이랑 설정은 필요 없을 것 같구 채팅 모달 height 살짝 줄이는 건 어떤가용 크기가 커야한다면 페이지 이동도 고려해 봐도 될 것 같습니당

@joarthvr
Copy link
Collaborator Author

joarthvr commented Dec 1, 2024

조금 더 길게 PR 끊어도 괜찮을 것 같음! 스타일 코드만 긴거라

채팅 탭에 알림이랑 설정은 필요 없을 것 같구 채팅 모달 height 살짝 줄이는 건 어떤가용 크기가 커야한다면 페이지 이동도 고려해 봐도 될 것 같습니당

height 줄여서 다음 pr에 반영하겠습닌다!

@joarthvr joarthvr merged commit 2f0e3c8 into dev Dec 1, 2024
1 check passed
@joarthvr joarthvr deleted the feat/#63-chatting-modal branch December 1, 2024 12:36
Copy link

github-actions bot commented Dec 1, 2024

⚡ Lighthouse report for http://localhost:3000/

Category Score
🔴 Performance 16
🟢 Accessibility 97
🟢 Best Practices 92
🟠 SEO 83

Detailed Metrics

Metric Value
🔴 First Contentful Paint 42.3 s
🔴 Largest Contentful Paint 71.3 s
🔴 Total Blocking Time 2,520 ms
🟢 Cumulative Layout Shift 0
🔴 Speed Index 56.9 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 🎨 Html&css 마크업 & 스타일링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants