remove lodash

.github/workflows/chromatic-ci.yaml

@@ -12,18 +12,24 @@ jobs:
         with:
           fetch-depth: 0 # needed by chromatic for git history
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.x
 
-      - name: PNPM cache via actions/cache@v3
-        id: pnpm-cache
-        uses: actions/cache@v3
+      - name: Cache Rush
+        uses: actions/cache@v4
         with:
-          path: /home/runner/work/design-system/design-system/common/temp/pnpm-store/v3
+          path: |
+            common/temp/install-run
+            ~/.rush
+          key: ${{ runner.os }}-rush-${{ hashFiles('rush.json') }}
+
+      - name: Cache PNPM
+        uses: actions/cache@v4
+        with:
+          path: common/temp/pnpm-store
           key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
-          restore-keys: |
-            ${{ runner.os }}-pnpm-
+          restore-keys: ${{ runner.os }}-pnpm-
 
       - name: Install dependencies
         run: node common/scripts/install-run-rush.js install

.github/workflows/continuous-integration.yml

@@ -11,26 +11,32 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
 
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
 
-      - name: PNPM cache via actions/cache@v3
-        id: pnpm-cache
-        uses: actions/cache@v3
+      - name: Cache Rush
+        uses: actions/cache@v4
         with:
-          path: /home/runner/work/design-system/design-system/common/temp/pnpm-store/v3
+          path: |
+            common/temp/install-run
+            ~/.rush
+          key: ${{ runner.os }}-rush-${{ hashFiles('rush.json') }}
+
+      - name: Cache PNPM
+        uses: actions/cache@v4
+        with:
+          path: common/temp/pnpm-store
           key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
-          restore-keys: |
-            ${{ runner.os }}-pnpm-
+          restore-keys: ${{ runner.os }}-pnpm-
 
       - name: Install dependencies
         run: node common/scripts/install-run-rush.js install

.github/workflows/npm-publish-beta.yaml

@@ -25,9 +25,9 @@ jobs:
           fetch-depth: 1
           token: ${{ secrets.GH_PAT }}
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.x
 
       - name: PNPM cache via actions/cache@v3
         id: pnpm-cache

.github/workflows/npm-publish.yaml

@@ -24,9 +24,9 @@ jobs:
           fetch-depth: 2
           token: ${{ secrets.GH_PAT }}
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.x
 
       - name: PNPM cache via actions/cache@v3
         id: pnpm-cache

.github/workflows/on-main.yml

@@ -13,9 +13,9 @@ jobs:
         with:
           fetch-depth: 0
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.x
 
       - name: PNPM cache via actions/cache@v3
         id: pnpm-cache

.github/workflows/release-branch.yaml

@@ -21,9 +21,9 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18.x
+          node-version: 20.x
 
       - name: PNPM cache via actions/cache@v3
         id: pnpm-cache

common/changes/pcln-carousel/no-mo-lodash_2024-01-24-03-39.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "removed lodash",
+      "type": "patch",
+      "packageName": "pcln-carousel"
+    }
+  ],
+  "packageName": "pcln-carousel",
+  "email": "[email protected]"
+}

common/changes/pcln-codemods/no-mo-lodash_2024-01-24-03-39.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "removed lodash",
+      "type": "patch",
+      "packageName": "pcln-codemods"
+    }
+  ],
+  "packageName": "pcln-codemods",
+  "email": "[email protected]"
+}

common/changes/pcln-design-system/no-mo-lodash_2024-01-24-03-39.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "removed lodash",
+      "type": "patch",
+      "packageName": "pcln-design-system"
+    }
+  ],
+  "packageName": "pcln-design-system",
+  "email": "[email protected]"
+}

common/changes/pcln-icons/no-mo-lodash_2024-01-24-03-39.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "removed lodash",
+      "type": "patch",
+      "packageName": "pcln-icons"
+    }
+  ],
+  "packageName": "pcln-icons",
+  "email": "[email protected]"
+}

common/changes/pcln-popover/no-mo-lodash_2024-01-24-04-02.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "removed lodash",
+      "type": "patch",
+      "packageName": "pcln-popover"
+    }
+  ],
+  "packageName": "pcln-popover",
+  "email": "[email protected]"
+}

common/config/rush/pnpm-config.json

@@ -125,11 +125,11 @@
    * PNPM documentation: https://pnpm.io/package_json#pnpmpackageextensions
    */
   "globalPackageExtensions": {
-    "babel-plugin-lodash": {
-      "dependencies": {
-        "@babel/types": "~7.20.0"
-      }
-    }
+    // "babel-plugin-lodash": {
+    //   "dependencies": {
+    //     "@babel/types": "~7.20.0"
+    //   }
+    // }
   },
 
   /**

packages/carousel/package.json

@@ -38,7 +38,6 @@
   },
   "dependencies": {
     "@styled-system/theme-get": "^5.1.2",
-    "lodash.debounce": "^4.0.8",
     "moize": "^6.1.6",
     "prop-types": "^15.8.1",
     "pure-react-carousel": "^1.30.1",

packages/carousel/src/helpers.js

@@ -1,14 +1,14 @@
-import { useState, useEffect } from 'react'
 import moize from 'moize'
+import { debounce } from 'pcln-design-system'
+import { useEffect, useState } from 'react'
 import { v4 as uuidv4 } from 'uuid'
 import {
-  VISIBLE_SLIDES_BREAKPOINT_1,
-  VISIBLE_SLIDES_BREAKPOINT_2,
   CAROUSEL_BREAKPOINT_1,
   CAROUSEL_BREAKPOINT_2,
   MEDIA_QUERY_MATCH,
+  VISIBLE_SLIDES_BREAKPOINT_1,
+  VISIBLE_SLIDES_BREAKPOINT_2,
 } from './constants'
-import debounce from 'lodash.debounce'
 
 const getSlideKey = moize(uuidv4, { profileName: 'getSlideKey' })
 
@@ -65,4 +65,4 @@ const getMobileVisibleSlidesArray = (visibleSlides) => [visibleSlides[0], null,
 const getMobileVisibleSlides = (visibleSlides) =>
   Array.isArray(visibleSlides) ? getMobileVisibleSlidesArray(visibleSlides) : visibleSlides
 
-export { getSlideKey, getVisibleSlidesArray, useResponsiveVisibleSlides, getMobileVisibleSlides }
+export { getMobileVisibleSlides, getSlideKey, getVisibleSlidesArray, useResponsiveVisibleSlides }

packages/codemods/package.json

@@ -27,7 +27,6 @@
     "inquirer": "^8.2.0",
     "is-git-clean": "^1.1.0",
     "jscodeshift": "^0.13.0",
-    "lodash.get": "^4.4.2",
     "meow": "^10.1.1",
     "pcln-design-system": "workspace:*",
     "prop-types": "^15.8.1",

packages/codemods/transforms/rename-deprecated-props-flex.js

@@ -1,10 +1,8 @@
-import get from 'lodash.get'
-
 const update = (path) => {
   const Node = path.value
 
   // Dumb way to skip text elements since they also can have an align prop
-  if (get(Node, 'openingElement.name.name', '').toLowerCase().includes('text')) {
+  if (Node?.openingElement?.name?.name?.toLowerCase()?.includes('text')) {
     return
   }
 

packages/core/config/jest.config.json

@@ -2,10 +2,10 @@
   "extends": "@priceline/heft-component-rig/profiles/react/config/jest.config.json",
   "coverageThreshold": {
     "global": {
-      "statements": 96,
-      "branches": 95,
-      "functions": 90,
-      "lines": 96
+      "statements": 94,
+      "branches": 89,
+      "functions": 89,
+      "lines": 94
     }
   }
 }

packages/core/package.json

@@ -79,7 +79,6 @@
     "@types/styled-system": "^5.1.22",
     "deepmerge": "^4.3.1",
     "hoist-non-react-statics": "^3.3.2",
-    "lodash": "^4.17.21",
     "react-element-to-jsx-string": "^15.0.0",
     "react-intersection-observer": "^9.5.3",
     "styled-system": "^5.1.5"

packages/core/src/DocsUtils/Section/Section.tsx

@@ -1,7 +1,7 @@
-import kebabCase from 'lodash/kebabCase'
 import React from 'react'
-
-import { Box, Text } from '../..'
+import { Box } from '../../Box/Box'
+import { Text } from '../../Text/Text'
+import { kebabCase } from '../../utils/strings'
 
 export type SectionProps = {
   heading: string

packages/core/src/DocsUtils/TableOfContents/TableOfContents.tsx

@@ -1,7 +1,7 @@
-import kebabCase from 'lodash/kebabCase'
 import React from 'react'
-
-import { Box, Link } from '../..'
+import { Box } from '../../Box/Box'
+import { Link } from '../../Link/Link'
+import { kebabCase } from '../../utils/strings'
 
 const scrollTo = (id: string) => document.getElementById(id)?.scrollIntoView({ behavior: 'smooth' })
 

packages/core/src/DocsUtils/utils.ts

@@ -1,6 +1,6 @@
 import { Story, StoryObj } from '@storybook/react'
-import kebabCase from 'lodash/kebabCase'
 import reactElementToJSXString from 'react-element-to-jsx-string'
+import { kebabCase } from '../utils/strings'
 
 export const copy = async (value: string) => navigator.clipboard.writeText(value)