Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sc-version-bump): uptick styled components to v5 #848

Closed
wants to merge 1 commit into from

Conversation

muddu-sreeram
Copy link
Collaborator

@codecov-commenter
Copy link

Codecov Report

Merging #848 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #848   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines          521       521           
=========================================
  Hits           521       521           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea4d08...c1172b7. Read the comment docs.

@sdalonzo
Copy link
Collaborator

sdalonzo commented Jun 8, 2020

This probably requires a broader discussion as raising the peer floor on SC will need to be a major and most apps are still on v3. Can you come to the WG meeting this week?

@muddu-sreeram
Copy link
Collaborator Author

muddu-sreeram commented Jun 10, 2020

This probably requires a broader discussion as raising the peer floor on SC will need to be a major and most apps are still on v3. Can you come to the WG meeting this week?

Now I think about it, I didn't have to loosen the peer dependency to >=3 because I think it's already >=3 ?

@sdalonzo
Copy link
Collaborator

This probably requires a broader discussion as raising the peer floor on SC will need to be a major and most apps are still on v3. Can you come to the WG meeting this week?

Now I think about it, I didn't have to loosen the peer dependency to >=3 because I think it's already >=3 ?

We left the peer loose so that apps can choose to use v5 if they want, I use it in some test apps I've worked on, we just aren't ready to require it.

@pcln-james pcln-james deleted the feat/styled-components-v5 branch December 29, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants