Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE_users profile text data - editation #39

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

prikryla
Copy link
Owner

Please review this PR of the editing user's profile. Thanks!

@prikryla prikryla linked an issue Nov 10, 2024 that may be closed by this pull request
@prikryla prikryla linked an issue Nov 10, 2024 that may be closed by this pull request
@janmrakava
Copy link
Collaborator

Code seems alright, but I have some notes.

  • Is there any chance to make some kind of documentation for API endpoints? For better FE developer experience
  • What about change password functionality? Will that be addressed separately in another issue?
  • We agreed that this is deferred functionality for now. Would it be possible to comment it somehow? Practically, it's dead code that may or may not be used in the future, if we understand each other.

@prikryla
Copy link
Owner Author

Documentation - I will explore the possibilities and will update you.
About this PR and text data issue - it focus on edit user's data, not the profile image, but the rest of the data. It seems that I messed up the naming of the branch? Also, the commit consists of the image part and the text part. My bad, will keep that in mind in the future, sorry. Please, review just the edit part of the user - edit username and email.

Password will have separate route - in detail described in the issue #37

@prikryla
Copy link
Owner Author

@janmrakava I've deleted the image handling from the code for now. We should make it from scratch again so at least now it will be deleted from the codebase. Review the stuff and mainly test it please.

@prikryla prikryla merged commit f74d0e8 into main Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BE - Route for user's profile text data
2 participants