Some fixes for components. #295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When freezed, all buttons and header icons are disabled.
Changed setTotalRecords behaviour: 1) If new page count is smaller than current page number, then new max page is set and paginate event triggered. 2) If new page count is higher or equal current page number, then doing nothing. Related to puidatatable, old behaviour works badly with lazy loading and filtering. When filtered data is received and applied, paginator is need to be updated.
Fixed initial lazy datasource call error when "rows" parameter was not filled from paginator options becouse in the initial call paginator is not yet created.
Added "renderData" event to catch table contents update if you want to bind any trigger handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Added ability to freeze dialog.
When freezed, all buttons and header icons are disabled
2. Update paginator.js
Changed setTotalRecords behaviour:
Related to puidatatable, old behaviour works badly with lazy loading and filtering. When filtered data is received and applied, paginator is need to be updated.
3. Update datatable.js
Fixed initial lazy datasource call error when "rows" parameter was not filled from paginator options becouse in the initial call paginator is not yet created.