Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Pricing options markup order #812

Merged
merged 10 commits into from
Nov 14, 2024

Conversation

danielguillan
Copy link
Contributor

@danielguillan danielguillan commented Nov 5, 2024

Summary

Resolves https://github.com/github/primer/issues/3727 and https://github.com/github/primer/issues/3729

Makes the content order in PricingOptions accessible by ensuring the heading is always first in the markup. Visual element order remains unchanged.

List of notable changes:

  • PricingOptions children are now rendered in a structured, predictable order.
  • Removed primary accent color override from stories to restore accessible contrast from the default accent color.

What should reviewers focus on?

  • Any visual regressions?
  • Test responsive behavior

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: e9c4e25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 5, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Nov 5, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@danielguillan danielguillan marked this pull request as ready for review November 13, 2024 11:49
Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @danielguillan 🙌

What do you think about adding a unit test for this (as a follow up) given how important element ordering is? It's come up a few times now, and is something we'd likely want to not regress on during future refactors.

@danielguillan danielguillan merged commit 8ce7656 into main Nov 14, 2024
18 checks passed
@danielguillan danielguillan deleted the danielguillan/fix-a11y-pricing-options branch November 14, 2024 13:15
@primer-css primer-css mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants