-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11y] Pricing options markup order #812
Conversation
🦋 Changeset detectedLatest commit: e9c4e25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
d7fb41b
to
4c13a6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @danielguillan 🙌
What do you think about adding a unit test for this (as a follow up) given how important element ordering is? It's come up a few times now, and is something we'd likely want to not regress on during future refactors.
Co-authored-by: Rez <[email protected]>
Summary
Resolves https://github.com/github/primer/issues/3727 and https://github.com/github/primer/issues/3729
Makes the content order in PricingOptions accessible by ensuring the heading is always first in the markup. Visual element order remains unchanged.
List of notable changes:
What should reviewers focus on?
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist: