Handle muted foreground color combined with default control backgro…

…und in dark mode (#782) * match muted bg to control bg * adjust fgcolor * revert bg color change * update legacy muted value * Create quick-experts-allow.md * github-actions[bot] Regenerated snapshots * Update quick-experts-allow.md --------- Co-authored-by: langermank <[email protected]>
primer · Nov 22, 2023 · ba763cc · ba763cc
1 parent 105afb5
commit ba763cc
Show file tree

Hide file tree

Showing 15 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/quick-experts-allow.md b/.changeset/quick-experts-allow.md
@@ -0,0 +1,6 @@
+---
+"@primer/primitives": patch
+---
+
+Update the muted foreground color to increase contrast against default controls in dark mode
+
diff --git a/...ybook-migration-tables--app-tokens-all-themes-dark-colorblind-theme-1-linux.png b/...ybook-migration-tables--app-tokens-all-themes-dark-colorblind-theme-1-linux.png
diff --git a/...pshots/storybook-migration-tables--app-tokens-all-themes-dark-theme-1-linux.png b/...pshots/storybook-migration-tables--app-tokens-all-themes-dark-theme-1-linux.png
diff --git a/...ybook-migration-tables--app-tokens-all-themes-dark-tritanopia-theme-1-linux.png b/...ybook-migration-tables--app-tokens-all-themes-dark-tritanopia-theme-1-linux.png
diff --git a/...rybook-migration-tables--fallbacks-all-themes-dark-colorblind-theme-1-linux.png b/...rybook-migration-tables--fallbacks-all-themes-dark-colorblind-theme-1-linux.png
diff --git a/...apshots/storybook-migration-tables--fallbacks-all-themes-dark-theme-1-linux.png b/...apshots/storybook-migration-tables--fallbacks-all-themes-dark-theme-1-linux.png
diff --git a/...rybook-migration-tables--fallbacks-all-themes-dark-tritanopia-theme-1-linux.png b/...rybook-migration-tables--fallbacks-all-themes-dark-tritanopia-theme-1-linux.png
diff --git a/...k-migration-tables--pattern-tokens-all-themes-dark-colorblind-theme-1-linux.png b/...k-migration-tables--pattern-tokens-all-themes-dark-colorblind-theme-1-linux.png
diff --git a/...ts/storybook-migration-tables--pattern-tokens-all-themes-dark-theme-1-linux.png b/...ts/storybook-migration-tables--pattern-tokens-all-themes-dark-theme-1-linux.png
diff --git a/...k-migration-tables--pattern-tokens-all-themes-dark-tritanopia-theme-1-linux.png b/...k-migration-tables--pattern-tokens-all-themes-dark-tritanopia-theme-1-linux.png
diff --git a/...ybook-migration-tables--primitives-all-themes-dark-colorblind-theme-1-linux.png b/...ybook-migration-tables--primitives-all-themes-dark-colorblind-theme-1-linux.png
diff --git a/...pshots/storybook-migration-tables--primitives-all-themes-dark-theme-1-linux.png b/...pshots/storybook-migration-tables--primitives-all-themes-dark-theme-1-linux.png
diff --git a/...ybook-migration-tables--primitives-all-themes-dark-tritanopia-theme-1-linux.png b/...ybook-migration-tables--primitives-all-themes-dark-tritanopia-theme-1-linux.png
diff --git a/data/colors/vars/global_dark.ts b/data/colors/vars/global_dark.ts
@@ -3,7 +3,7 @@ import {alpha, get} from '../../../src/utils-v1'
 export default {
   fg: {
     default: '#e6edf3',
-    muted: '#7d8590',
+    muted: '#848d97',
     subtle: get('scale.gray.4'),
     onEmphasis: get('scale.white')
   },

diff --git a/src/tokens/functional/color/dark/primitives-dark.json5 b/src/tokens/functional/color/dark/primitives-dark.json5
@@ -35,7 +35,7 @@
       },
       mix: {
         color: '{base.color.gray.4}',
-        weight: 0.5,
+        weight: 0.25,
       },
     },
     onEmphasis: {