Docs: Fix broken and incomplete storybook stories #1063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Saw some broken stories in our docs/storybooks, some examples:
And some stories with missing information (mainly source value):
-https://primer.style/foundations/typography
Looks like at some point the .json info files renamed property from
value
to$value
, adjusting stories to reflect that.List of notable changes:
...original.value
to...original.$value
in storybook stories that pull data fromdocs/**/.json
filesdescription
instead ofcomment
in Typography Functional Overview story.What should reviewers focus on?
Steps to test:
source value
and that previously listed "broken" stories are now able to renderSupporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist: