-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issues in a11y themes #1154
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 6cca25b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Design Token Diff (CSS)
|
Design Token Diff (StyleLint)
|
Design Token Diff (Figma)
|
0025407
to
b3c0518
Compare
b3c0518
to
016fce2
Compare
@lukasoppermann I think the approach I would take here would be to restore colors as close as possible to the hue range used prior to this update—unsure what colors were used where, however. |
I actually got confused by some of the comments in slack. Looking at this PR's change in VRT data: https://github.com/primer/primitives/pull/1136/files I believe that the original version was using red / orange for open which makes sense in terms of easy to differentiate. So if there are no concerns I will go back to this. |
Summary
This is the implementation of the fix for https://github.com/github/primer/issues/4667
Discussion point
As one can see in the screenshots below, while blue may "feel" more fitting for "open", it contrasts a lot worse with other colors like "done" (purple).
I believe this is why the theme originally used red instead of blue (light mode was like this, dark mode had a bug which is why it never showed up as red).
Possible solutions
Changes
open
colors to referencesuccess
colors for Dark and Light Tritanopiaopen
closed
GitHub UI
Light Tritanopia
Dark Tritanopia
Light Protanopia & Deuteranopia
Dark Protanopia & Deuteranopia