Merge branch 'main' into toggle-switch-a11y-fixes

primer · Jan 17, 2025 · be8dd43 · be8dd43
2 parents e4060ce + c87e80c
commit be8dd43
Show file tree

Hide file tree

Showing 2,142 changed files with 25,238 additions and 15,497 deletions.
diff --git a/.changeset/brave-cheetahs-prove.md b/.changeset/brave-cheetahs-prove.md
diff --git a/.changeset/calm-meals-impress.md b/.changeset/calm-meals-impress.md
diff --git a/.changeset/chilled-goats-visit.md b/.changeset/chilled-goats-visit.md
diff --git a/.changeset/curly-bikes-burn.md b/.changeset/curly-bikes-burn.md
diff --git a/.changeset/dry-seals-count.md b/.changeset/dry-seals-count.md
diff --git a/.changeset/fair-wolves-attack.md b/.changeset/fair-wolves-attack.md
diff --git a/.changeset/fast-hats-drum.md b/.changeset/fast-hats-drum.md
diff --git a/.changeset/gentle-yaks-shake.md b/.changeset/gentle-yaks-shake.md
diff --git a/.changeset/giant-bees-impress.md b/.changeset/giant-bees-impress.md
@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+Fix an issue in useAnnouncements.tsx causing a TypeError in production. The activeItem variable may be null.
diff --git a/.changeset/grumpy-cherries-deny.md b/.changeset/grumpy-cherries-deny.md
diff --git a/.changeset/honest-plums-approve.md b/.changeset/honest-plums-approve.md
diff --git a/.changeset/lazy-jars-leave.md b/.changeset/lazy-jars-leave.md
@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+Avoid accessing properties of potentially null document.body in PageLayout
diff --git a/.changeset/lovely-stingrays-jog.md b/.changeset/lovely-stingrays-jog.md
diff --git a/.changeset/odd-seas-study.md b/.changeset/odd-seas-study.md
diff --git a/.changeset/old-weeks-matter.md b/.changeset/old-weeks-matter.md
diff --git a/.changeset/polite-ligers-exercise.md b/.changeset/polite-ligers-exercise.md
diff --git a/.changeset/real-fans-tap.md b/.changeset/real-fans-tap.md
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -1,7 +1,7 @@
 {
   "name": "Primer React",
   "image": "mcr.microsoft.com/vscode/devcontainers/typescript-node:22",
-  "extensions": ["esbenp.prettier-vscode", "dbaeumer.vscode-eslint", "DavidAnson.vscode-markdownlint"],
+  "extensions": ["esbenp.prettier-vscode", "dbaeumer.vscode-eslint", "DavidAnson.vscode-markdownlint", "hex-ci.stylelint-plus"],
   "forwardPorts": [8000],
   "onCreateCommand": ["/bin/bash", "-c", "npm run setup"],
   "remoteUser": "node",

diff --git a/.eslintrc.js b/.eslintrc.js
@@ -17,6 +17,7 @@ module.exports = {
     'plugin:primer-react/recommended',
     'plugin:import/typescript',
     'plugin:ssr-friendly/recommended',
+    'plugin:clsx/recommended',
   ],
   settings: {
     react: {
@@ -200,8 +201,14 @@ module.exports = {
       parserOptions: {
         project: 'tsconfig.json',
       },
-      extends: ['plugin:playwright/jest-playwright'],
-      rules: {},
+      extends: ['plugin:playwright/recommended'],
+      rules: {
+        'playwright/expect-expect': 'off',
+        'playwright/no-conditional-expect': 'off',
+        'playwright/no-conditional-in-test': 'off',
+        'playwright/no-wait-for-selector': 'off',
+        'playwright/valid-title': 'off',
+      },
     },
 
     // rules which apply only to Markdown

diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -13,6 +13,11 @@ updates:
     labels:
       - 'dependencies'
       - 'skip changeset'
+    groups:
+      storybook:
+        patterns:
+          - '@storybook/*'
+          - 'storybook'
 
   - package-ecosystem: 'github-actions'
     directory: '/'

diff --git a/.github/workflows/accessibility-alt-text-bot.yml b/.github/workflows/accessibility-alt-text-bot.yml
@@ -5,9 +5,11 @@ on:
   pull_request:
     types: [opened, edited]
   issue_comment:
-    types: [created, edited]
+    types: [created, edited, deleted]
   discussion:
     types: [created, edited]
+  discussion_comment:
+    types: [created, edited, deleted]
 
 permissions:
   issues: write
@@ -21,4 +23,4 @@ jobs:
     if: ${{ github.event.issue || github.event.pull_request || github.event.discussion  }}
     steps:
       - name: Get action 'github/accessibility-alt-text-bot'
-        uses: github/accessibility-alt-text-bot@v1.5.0
+        uses: github/accessibility-alt-text-bot@v1.6.0
diff --git a/.github/workflows/assign_release_conductor.yml b/.github/workflows/assign_release_conductor.yml
@@ -18,7 +18,6 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: 22
-      - run: npm i -g npm@^10.5.1
       - run: npm ci
       - uses: ./.github/actions/pagerduty
         id: pagerduty

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -27,7 +27,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Check for unformatted files
@@ -43,7 +42,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Lint JavaScript
@@ -63,7 +61,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build
@@ -81,7 +78,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build project
@@ -99,7 +95,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build
@@ -118,7 +113,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build storybook
@@ -159,7 +153,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: install dependencies
         run: npm ci
       - name: download all reports
@@ -196,7 +189,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build storybook
@@ -237,7 +229,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: install dependencies
         run: npm ci
       - name: download all reports
@@ -270,7 +261,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build storybook
@@ -311,7 +301,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: install dependencies
         run: npm ci
       - name: download all reports
@@ -348,7 +337,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build storybook
@@ -389,7 +377,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: install dependencies
         run: npm ci
       - name: download all reports
@@ -419,11 +406,17 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
+      - name: Build storybook to generate story IDs
+        run: npm run build:storybook
+        working-directory: packages/react
       - name: Build components.json
-        run: npm run build:components.json
+        run: npx tsx script/components-json/build.ts --storybook-data 'storybook-static/index.json'
+        working-directory: packages/react
+      - name: Build hooks.json
+        run: npx tsx script/hooks-json/build.ts'
+        working-directory: packages/react
 
   sizes:
     runs-on: ubuntu-latest
@@ -435,7 +428,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build

diff --git a/.github/workflows/codescan.yml b/.github/workflows/codescan.yml
@@ -18,7 +18,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
 

diff --git a/.github/workflows/consumer_test.yml b/.github/workflows/consumer_test.yml
diff --git a/.github/workflows/deploy_preview.yml b/.github/workflows/deploy_preview.yml
@@ -18,7 +18,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build docs preview

diff --git a/.github/workflows/deploy_preview_forks.yml b/.github/workflows/deploy_preview_forks.yml
@@ -19,7 +19,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build docs preview

diff --git a/.github/workflows/release-schedule.yml b/.github/workflows/release-schedule.yml
@@ -31,7 +31,6 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 22
-      - run: npm i -g npm@^10.5.1
       - name: Install packages for github-script
         run: npm i date-fns
       - name: Create Release Issue

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -24,7 +24,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
 
       - name: Install dependencies
         run: npm ci