fix(Button): do not render main spinner if there is a count when load…

…ing (#5605) * fix(Button): do not render main spinner if there is a count when loading * Create itchy-numbers-fetch.md --------- Co-authored-by: Jon Rohan <[email protected]>
primer · Jan 29, 2025 · d14c48c · d14c48c
1 parent 2db6c92
commit d14c48c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.changeset/itchy-numbers-fetch.md b/.changeset/itchy-numbers-fetch.md
@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+fix(Button): do not render main spinner if there is a count when loading
diff --git a/packages/react/src/Button/ButtonBase.tsx b/packages/react/src/Button/ButtonBase.tsx
@@ -141,6 +141,7 @@ const ButtonBase = forwardRef(
                       !LeadingVisual &&
                       !TrailingVisual &&
                       !TrailingAction &&
+                      count === undefined &&
                       renderModuleVisual(Spinner, loading, 'loadingSpinner', false)
                   }
                   {
@@ -258,6 +259,7 @@ const ButtonBase = forwardRef(
                     !LeadingVisual &&
                     !TrailingVisual &&
                     !TrailingAction &&
+                    count === undefined &&
                     renderModuleVisual(Spinner, loading, 'loadingSpinner', false)
                 }
                 {