Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): update Node.js to v20 LTS #3940

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Nov 13, 2023

Given that Node.js is now on v21, we have an LTS version at v20 that we can migrate to 👀

Changelog

New

Changed

  • Update .nvmrc to use v20
  • Update GitHub Actions to use Node.js v20

Removed

Rollout strategy

None

Testing & Reviewing

  • Verify that CI jobs continue to work as expected 😅
  • Verify storybook continues to run as expected locally
  • Verify that Gatsby continues to run as expected locally

@joshblack joshblack requested review from a team and broccolinisoup November 13, 2023 22:14
Copy link

changeset-bot bot commented Nov 13, 2023

⚠️ No Changeset found

Latest commit: 2928b47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Nov 13, 2023
Copy link
Contributor

github-actions bot commented Nov 13, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.36 KB (0%)
dist/browser.umd.js 104.91 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-3940 November 22, 2023 11:05 Inactive
@pksjce
Copy link
Contributor

pksjce commented Nov 22, 2023

Tried this out and could not start docs for some reason. Did you face any similar issues?

@broccolinisoup
Copy link
Member

@pksjce I didn't have any issues running docs or storybook on this PR. What is the error you are seeing on the docs? Josh recently helped me fix some local docs issue so I can try helping you 🙌🏻

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be in order ✨ Hope the GH actions will like v20 too 🤞🏻

@joshblack joshblack added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit 8c96909 Nov 28, 2023
31 checks passed
@joshblack joshblack deleted the chore/update-nodejs-to-v20-lts branch November 28, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants