SelectPanel2: Props for docs page #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
siddharthkp
commented
Nov 21, 2023
•
siddharthkp
commented
- Follow up for SelectPanel2: Types! #3929 (can be merged independently)
- Preview: https://primer-33758cc5e6-13348165.drafts.github.io/drafts/SelectPanel
- Stories/examples are not in this PR, need to clean up stories before I can add them :)
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
pksjce
reviewed
Nov 22, 2023
|
|
||
| import data from '../../../src/drafts/SelectPanel2/SelectPanel.docs.json' | ||
|
|
||
| A `SelectPanel` provides an anchor that will open an overlay with a list of selectable items, and a text input to filter the selectable items |
There was a problem hiding this comment.
Is this a good place to describe more differences between this vs ActionMenu and that this component replaces FilteredList ?
There was a problem hiding this comment.
Not anymore :)
That job is now done by the design guidelines: https://primer.style/components/selectpanel
SelectPanel.mdx in this repo is temporary because primer/react docs wouldn't be around for much longer
broccolinisoup
approved these changes
Nov 23, 2023
| @@ -168,6 +168,8 @@ | |||
| url: /drafts/MarkdownViewer | |||
| - title: PageHeader | |||
| url: /drafts/PageHeader | |||
| - title: SelectPanel v2 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.