Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectPanel2: Clean up stories #3962

Merged
merged 41 commits into from
Dec 5, 2023
Merged

SelectPanel2: Clean up stories #3962

merged 41 commits into from
Dec 5, 2023

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Nov 21, 2023 •
edited
Loading

@siddharthkp
breaking changes + cleanup
6a12091
@siddharthkp
add SelectPanel.Warning
f584204
@siddharthkp
add link styles
6d56c15
@siddharthkp
remove todo story :)
6a30cf3
@siddharthkp
typo
52a3608
@siddharthkp
I not H
5309eb1
@siddharthkp
change example from labels to assignees
8930146
@siddharthkp
1. make it work....
96f4ca0
@siddharthkp
move implementation details from story → component
4393e0c
@siddharthkp
absorb EmptyMessage into SelectPanel.Message
d42096e
@siddharthkp
absorb WarningMessage into SelectPanel.Message
cda8096
@siddharthkp
absorb ErrorMessage into SelectPanel.Message
310fefe
@siddharthkp
stricter types for empty
336b42e
@siddharthkp
clean up lint errors
8d15989
@siddharthkp
Merge branch 'main' into drafts-selectpanel-validation
8cc84c6
@siddharthkp
tiny cleanup for bug
24127c1
@siddharthkp
clean up message types real good!
db5359f
@siddharthkp
child can be null
68af462
@siddharthkp
types: first round
bd44d73
@siddharthkp
types: round 2 - cleanup
030416b
@siddharthkp
types: round 3 more cleanup
20cc878
@siddharthkp
types: 4 clean up stories ignores
abfa75c
@siddharthkp
types: 5 clean up stories
bac97c2
@siddharthkp
Merge branch 'main' into drafts-selectpanel-types
3f0b47a
@siddharthkp
SelectPanel.Loading no longer exists
0afa927
@siddharthkp
Revert "SelectPanel.Loading no longer exists"
540e2d3 
This reverts commit 0afa927.
@siddharthkp
step 1
aade644
@siddharthkp
default story - done
0b748ad
@siddharthkp
split stories between examples and features
2e30ea6
@siddharthkp
remove default open from stories
6d0e281
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.23 KB (0%)
dist/browser.umd.js 104.75 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-3962 November 21, 2023 15:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3962 November 21, 2023 15:42 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3962 November 21, 2023 16:08 Inactive
@siddharthkp siddharthkp marked this pull request as ready for review November 23, 2023 15:31
broccolinisoup
broccolinisoup approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stories are all looking good to me overall. Just left a question. Let me know if there is any specific feedback you are after in the stories!

src/drafts/SelectPanel2/stories/SelectPanel.default.stories.tsx
<SelectPanel
title="Select labels"
onSubmit={onSubmit}
onCancel={() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a good place to utilize storybook actions or is this story generic enough that we don't need actions?

I don't think I'm utilizing them as much, Josh brought it to my attention in one of the code reviews and I am curious what you think about them as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'm utilizing them as much

Same! I rarely think of them 😅

I've added them to the playground now. Let's see if they are useful

@github-actions github-actions bot temporarily deployed to storybook-preview-3962 November 28, 2023 14:22 Inactive
Base automatically changed from drafts-selectpanel-types to main December 5, 2023 13:46
@github-actions github-actions bot temporarily deployed to storybook-preview-3962 December 5, 2023 14:43 Inactive
@siddharthkp siddharthkp enabled auto-merge December 5, 2023 14:56
@siddharthkp siddharthkp added this pull request to the merge queue Dec 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2023
@siddharthkp siddharthkp added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 91642f7 Dec 5, 2023
28 checks passed
@siddharthkp siddharthkp deleted the drafts-selectpanel-stories-setup branch December 5, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

Assignees

@siddharthkp siddharthkp

Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharthkp @broccolinisoup