Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drafts: remove Button2 #3985

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Drafts: remove Button2 #3985

merged 1 commit into from
Dec 4, 2023

Conversation

siddharthkp
Copy link
Member

Button2 was an experiment in authoring and shipping css, it has served it's purpose and we can remove it now

Should be safe, we don't export this component anywhere and it's not used anywhere in dotcom

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Nov 29, 2023
@siddharthkp siddharthkp self-assigned this Nov 29, 2023
@siddharthkp siddharthkp requested a review from a team November 29, 2023 13:47
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2023

⚠️ No Changeset found

Latest commit: 902f1ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 104.56 KB (0%)
dist/browser.umd.js 105.1 KB (0%)

@siddharthkp siddharthkp added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 9bcec87 Dec 4, 2023
32 checks passed
@siddharthkp siddharthkp deleted the remove-drafts-button2 branch December 4, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksjce pksjce pksjce approved these changes

@joshblack joshblack joshblack approved these changes

@langermank langermank langermank approved these changes

Assignees

@siddharthkp siddharthkp

Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siddharthkp @pksjce @joshblack @langermank