Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AvatarStack): Convert AvatarStack to CSS modules behind team feature flag #5087

Merged
merged 24 commits into from
Oct 31, 2024
Merged

feat(AvatarStack): Convert AvatarStack to CSS modules behind team feature flag #5087

merged 24 commits into from
Oct 31, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 8, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4024

Changelog

New

Changed

Convert AvatarStack to CSS modules behind team feature flag

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: dcb115d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 8, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5087 October 8, 2024 18:33 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.62 KB (+0.21% 🔺)
packages/react/dist/browser.umd.js 97.94 KB (+0.15% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5087 October 8, 2024 18:40 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5087 October 8, 2024 20:20 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5087 October 8, 2024 21:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5087 October 21, 2024 20:10 Inactive
@primer-integration
Copy link

primer-integration bot commented Oct 21, 2024 •
edited
Loading

🟢 golden-jobs completed with status success.

@jonrohan jonrohan marked this pull request as ready for review October 24, 2024 23:07
@jonrohan jonrohan requested a review from a team as a code owner October 24, 2024 23:07
@jonrohan jonrohan requested review from camertron and joshblack and removed request for camertron October 24, 2024 23:07
@github-actions github-actions bot temporarily deployed to storybook-preview-5087 October 28, 2024 21:02 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5087 October 28, 2024 21:17 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/349070

joshblack
joshblack reviewed Oct 29, 2024
View reviewed changes
packages/react/src/AvatarStack/AvatarStack.tsx
data-responsive={enabled && (!size || isResponsiveValue(size)) ? '' : undefined}
className={clsx(wrapperClassNames, {[classes.AvatarStack]: enabled})}
// @ts-ignore - it's not allowing CSS properties here
style={enabled ? (getResponsiveAvatarSizeStyles() as React.CSSProperties) : undefined}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help if getResponseiveAvatarSizeStyles returned React.CSSProperties or not really? Wasn't sure what would help out best with the type casting in the file, either way works.

@jonrohan jonrohan requested a review from joshblack October 30, 2024 19:51
@jonrohan jonrohan added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 7efa934 Oct 31, 2024
43 checks passed
@jonrohan jonrohan deleted the css_modules_avatar_stack branch October 31, 2024 20:42
@primer primer bot mentioned this pull request Oct 31, 2024
Merged
@joshblack joshblack mentioned this pull request Nov 1, 2024
Merged
@jonrohan jonrohan restored the css_modules_avatar_stack branch November 14, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @joshblack