Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing stories, simplify Autocomplete stories #5127

Merged
merged 21 commits into from
Oct 22, 2024
Merged

Add missing stories, simplify Autocomplete stories #5127

merged 21 commits into from
Oct 22, 2024

Conversation

mperrotti
Copy link
Contributor

New stories added:

  • Autocomplete
    • Playground story
  • Select
    • placeholder
  • Textarea
    • rows (custom width)
    • columns (custom height)
    • resize - all options
  • TextInputWithTokens
    • maxHeight
    • preventTokenWrapping
    • size
    • visibleTokenCount (truncating tokens)

In addition to these new stories, the Autocomplete stories have been updated to only use Storybook controls for the Playground story.

Changelog

There is nothing in these changes that require a release.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why
    • These are just changes to Storybook

Testing & Reviewing

Merge checklist

@mperrotti mperrotti added skip changeset This change does not need a changelog update snapshots labels Oct 15, 2024
@mperrotti mperrotti requested a review from a team as a code owner October 15, 2024 17:59
@mperrotti mperrotti requested a review from langermank October 15, 2024 17:59
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bf87c9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-5127 October 15, 2024 18:02 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.9 KB (0%)
packages/react/dist/browser.umd.js 97.25 KB (0%)

mperrotti
mperrotti commented Oct 15, 2024
View reviewed changes
script/generate-e2e-tests.js Outdated
@@ -1090,6 +1090,10 @@ const components = new Map([
id: 'components-select-features--with-option-groups',
name: 'With Option Groups',
},
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something else I need to do besides updating this script? I'm not seeing any new snapshots get added.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mperrotti this file has really gotten old so one thing could be to update the test file directly to use the new array pattern we've been doing: https://github.com/primer/react/blob/main/e2e/components/Link.test.ts#L5 and updating it there 👀

@github-actions github-actions bot temporarily deployed to storybook-preview-5127 October 15, 2024 18:52 Inactive
joshblack
joshblack approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let me know if I can help out at all with the VRT stuff 👀

script/generate-e2e-tests.js Outdated
@@ -1090,6 +1090,10 @@ const components = new Map([
id: 'components-select-features--with-option-groups',
name: 'With Option Groups',
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mperrotti this file has really gotten old so one thing could be to update the test file directly to use the new array pattern we've been doing: https://github.com/primer/react/blob/main/e2e/components/Link.test.ts#L5 and updating it there 👀

@github-actions github-actions bot temporarily deployed to storybook-preview-5127 October 15, 2024 23:50 Inactive
@primer primer bot requested a review from a team as a code owner October 17, 2024 20:17
@primer primer bot temporarily deployed to github-pages October 17, 2024 20:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5127 October 17, 2024 20:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5127 October 21, 2024 14:53 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5127 October 21, 2024 22:29 Inactive
@primer primer bot temporarily deployed to github-pages October 21, 2024 22:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5127 October 21, 2024 22:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5127 October 22, 2024 15:13 Inactive
@primer primer bot temporarily deployed to github-pages October 22, 2024 15:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5127 October 22, 2024 15:23 Inactive
@mperrotti mperrotti enabled auto-merge October 22, 2024 19:17
@mperrotti mperrotti added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 016f760 Oct 22, 2024
43 checks passed
@mperrotti mperrotti deleted the mp/story-improvements-10.2024 branch October 22, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mperrotti @joshblack