Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ActionList.LinkItem duplicate classes #5515

Closed
wants to merge 3 commits into from
Closed

fix: ActionList.LinkItem duplicate classes #5515

wants to merge 3 commits into from

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Jan 9, 2025 •
edited
Loading

Part of https://github.com/github/primer/issues/4570

Fixes an issue where className was being duplicated in LinkItem on both the wrapper li (correct) and the inner a tag (incorrect).

Changelog

Removed

  • Removes className from menuItemProps in ActionList.Item

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b919972

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jan 9, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5515 January 9, 2025 15:07 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.89 KB (-0.04% 🔽)
packages/react/dist/browser.umd.js 104.21 KB (-0.02% 🔽)

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/357139

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 9, 2025
@francinelucca francinelucca changed the title TEST: ActionList repro fix: ActionList.LinkItem duplicate classes Jan 9, 2025
@francinelucca
Copy link
Member Author

closing in favor of #5517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@francinelucca