Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy_preview.yml workflow #5523

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix deploy_preview.yml workflow #5523

merged 1 commit into from
Jan 10, 2025

Conversation

hussam-i-am
Copy link
Contributor

@hussam-i-am hussam-i-am commented Jan 9, 2025 •
edited
Loading

Followup to #5499

Changelog

New

Changed

  • Removes the branch setting to see if that will resolve the issue of deploy_preview.yml not running as expected

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Only contains workflow changes

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Jan 9, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8ca3f3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.18 KB (0%)
packages/react/dist/browser.umd.js 104.52 KB (0%)

@github-actions github-actions bot temporarily deployed to vrt-all-flags-5523 January 9, 2025 19:15 Inactive
@github-actions github-actions bot temporarily deployed to vrt-no-flag-5523 January 9, 2025 19:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5523 January 9, 2025 19:15 Inactive
@github-actions github-actions bot temporarily deployed to aat-no-flag-5523 January 9, 2025 19:15 Inactive
@github-actions github-actions bot temporarily deployed to aat-all-flags-5523 January 9, 2025 19:15 Inactive
@hussam-i-am hussam-i-am changed the base branch from main to hussam-i-am/preview-page January 9, 2025 19:42
@github-actions github-actions bot requested a deployment to vrt-all-flags-5523 January 9, 2025 19:45 Abandoned
@github-actions github-actions bot requested a deployment to aat-no-flag-5523 January 9, 2025 19:45 Abandoned
@github-actions github-actions bot requested a deployment to vrt-no-flag-5523 January 9, 2025 19:45 Abandoned
@github-actions github-actions bot requested a deployment to aat-all-flags-5523 January 9, 2025 19:45 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-5523 January 9, 2025 19:45 Abandoned
@github-actions github-actions bot temporarily deployed to aat-no-flag-5523 January 9, 2025 20:00 Inactive
@github-actions github-actions bot temporarily deployed to vrt-no-flag-5523 January 9, 2025 20:00 Inactive
@github-actions github-actions bot temporarily deployed to vrt-all-flags-5523 January 9, 2025 20:00 Inactive
@github-actions github-actions bot temporarily deployed to aat-all-flags-5523 January 9, 2025 20:00 Inactive
@hussam-i-am hussam-i-am mentioned this pull request Jan 9, 2025
Merged
13 tasks
Base automatically changed from hussam-i-am/preview-page to main January 10, 2025 19:26
@hussam-i-am hussam-i-am changed the title [Do Not Merge] Preview page with failed vrt Fix deploy_preview.yml workflow Jan 10, 2025
@hussam-i-am hussam-i-am marked this pull request as ready for review January 10, 2025 19:48
@hussam-i-am hussam-i-am requested a review from a team as a code owner January 10, 2025 19:48
@hussam-i-am hussam-i-am requested a review from mperrotti January 10, 2025 19:48
@hussam-i-am
Copy link
Contributor Author

@joshblack Still not seeing deploy_preview run, making an additional change to see if this will resolve it.

@hussam-i-am hussam-i-am requested a review from joshblack January 10, 2025 20:04
@hussam-i-am hussam-i-am force-pushed the hussam-i-am/preview-page-fail branch from 67f08d8 to 8ca3f3d Compare January 10, 2025 20:18
@hussam-i-am hussam-i-am enabled auto-merge January 10, 2025 20:24
@hussam-i-am hussam-i-am added this pull request to the merge queue Jan 10, 2025
@joshblack joshblack added the skip changeset This change does not need a changelog label Jan 10, 2025
Merged via the queue into main with commit e2075bd Jan 10, 2025
41 of 42 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/preview-page-fail branch January 10, 2025 20:52
@hussam-i-am hussam-i-am mentioned this pull request Jan 10, 2025
Merged
13 tasks
joshblack added a commit that referenced this pull request Jan 13, 2025
@joshblack
Revert "Remove branch from preview_deploy.yml (#5523)"
a89b3da 
This reverts commit e2075bd.
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
@joshblack
revert: restore deploy preview behavior (#5536)
15270ac 
* Revert "Fix Prod Storybook deployment (#5535)"

This reverts commit 8b96591.

* Revert "fix: deploy_preview workflow (#5529)"

This reverts commit be42cc6.

* Revert "Fixing deploy_preview workflow (#5526)"

This reverts commit 62353f2.

* Revert "Remove branch from preview_deploy.yml (#5523)"

This reverts commit e2075bd.

* Revert "Add landing page and upload vrt/aat reports to GitHub Pages (#5499)"

This reverts commit 5a6d7bb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/engineer-reviewers

Assignees

@hussam-i-am hussam-i-am

Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hussam-i-am @joshblack