-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update dynamic button examples to use AriaAlert #5548
Conversation
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! We could also include these in our e2e tests for vrt/axe too if that'd be helpful by updating: https://github.com/primer/react/blob/main/e2e/components/Banner.test.ts#L6
.changeset/six-cats-tease.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For docs updates should be good with no changeset! I can add a skip changeset label if that would help 👀
ead8595
to
acd95e5
Compare
Welp, looks like |
Closes https://github.com/github/accessibility-audits/issues/10017
Changelog
Changed
AriaAlert
to ensure dynamic banner content is announced.features
folder will help improve discoverability for this common usecase.Rollout strategy
Testing & Reviewing
Merge checklist