-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SelectPanel): pass anchorId to AnchoredOverlay #5549
base: main
Are you sure you want to change the base?
Conversation
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
🦋 Changeset detectedLatest commit: 982d4f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358074 |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Closes https://github.com/github/accessibility-audits/issues/10036
Changelog
A FormControl's Label is not currently being associated with the SelectPanel control due to the id not being passed to the AnchoredOverlay. This PR explicitly passes the ID provided to the
SelectPanel
to theAnchoredOverlay
's menu.Changed
anchorId
Rollout strategy
Testing & Reviewing
Go to deployment, use voiceover to verify the label gets read along with the control. Compare to production where it doesn't
Merge checklist