Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Storybook] Add aria-labels to the multiple item progress bar #5559

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Draft

[Accessibility][Storybook] Add aria-labels to the multiple item progress bar #5559

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80d6f8f
[Accessibility][Storybook] Add aria-labels to the multiple-item progr…
kendallgassner Jan 16, 2025
4a800c6
Update aria-label capitalization in ProgressBar stories
kendallgassner Jan 16, 2025
fcda31a
Remove extra inported component
kendallgassner Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/react/src/ProgressBar/ProgressBar.features.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react'
import type {Meta} from '@storybook/react'
import {ProgressBar} from '..'
import {ProgressBar, Text} from '..'

Check failure on line 3 in packages/react/src/ProgressBar/ProgressBar.features.stories.tsx

View workflow job for this annotation

GitHub Actions / lint 

'Text' is defined but never used
kendallgassner marked this conversation as resolved.
Show resolved Hide resolved

export default {
title: 'Components/ProgressBar/Features',
Expand All @@ -19,10 +19,10 @@
export const Color = () => <ProgressBar progress="66" bg="done.emphasis" aria-label="Upload test.png" />

export const MultipleItems = () => (
<ProgressBar aria-valuenow={70} aria-label="Upload test.png">
<ProgressBar.Item progress={33} sx={{bg: 'accent.emphasis'}} />
<ProgressBar.Item progress={23} bg={'danger.emphasis'} />
<ProgressBar.Item progress={14} bg={'severe.emphasis'} />
<ProgressBar>
<ProgressBar.Item progress={33} aria-label="Photo usage" sx={{bg: 'accent.emphasis'}} />
<ProgressBar.Item progress={23} aria-label="Application usage" bg={'danger.emphasis'} />
<ProgressBar.Item progress={14} aria-label="Music usage" bg={'severe.emphasis'} />
</ProgressBar>
)

Expand Down
Loading