Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building components.json #5579

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Fix building components.json #5579

merged 1 commit into from
Jan 21, 2025

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Jan 21, 2025 •
edited
Loading

Changelog

New

Changed

  1. Fixes ci.yml so building components.json works again.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

This is a CI-only change.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 718fe2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-5579 January 21, 2025 18:47 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.25 KB (0%)
packages/react/dist/browser.umd.js 104.56 KB (0%)

@camertron camertron force-pushed the fix_components_dot_json branch from fe8eec1 to 718fe2b Compare January 21, 2025 18:49
@camertron camertron added the skip changeset This change does not need a changelog label Jan 21, 2025
@camertron camertron changed the title Debug bulding components.json Fix building components.json Jan 21, 2025
@camertron camertron marked this pull request as ready for review January 21, 2025 18:56
@camertron camertron requested a review from a team as a code owner January 21, 2025 18:56
@camertron camertron requested a review from joshblack January 21, 2025 18:56
@joshblack joshblack added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 43acb7f Jan 21, 2025
47 of 48 checks passed
@joshblack joshblack deleted the fix_components_dot_json branch January 21, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camertron @joshblack