-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add inactive
argument to Button view component docs
#3276
Conversation
|
|
Uhhh... no idea what's going on with the addition of 973 component snapshot files. My changes didn't touch the UI. I added one code comment to one file 😬 |
This reverts commit dd2b7ad.
Yikes... I pushed a revert commit, and the files changed count more than doubled 😬 I'll try dropping instead of reverting. If that doesn't do anything, I guess I'll open a new PR. |
Yeah, something's up with the git history, so I wasn't able to drop the snapshot commits. Closing in favor of #3278 |
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
While working on https://github.com/github/pull-requests/issues/15457, I noticed that the
inactive
argument wasn't documented for the Button view component. I added it to the component file here.List the issues that this change affects.
Related to https://github.com/github/pull-requests/issues/15457
Risk Assessment
What approach did you choose and why?
I copied the text from the base button component, which does include this argument. Ideally, we wouldn't have to dupe things in both components, but as far as I can tell, this is currently the only way to do it.
Anything you want to highlight for special attention from reviewers?
Nothing in particular.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.