Resolve an issue when attempting to call decode() on a streamed/potentially temporarily invalid utf-8 string. #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tially temporarily invalid utf-8 string.
klieret
approved these changes
Aug 31, 2024
|
Thanks for this change @blahblahasdf + @klieret for approving! Merging this edit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #215
What does this implement/fix? Explain your changes.
Instead of accumulating the
exec_resultas the content is streamed back from the container as a utf-8 decoded string store it as bytes and decode only when returning the results.Any other comments?