Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add note under datetime in schema reference #5801

Merged
merged 6 commits into from
May 2, 2024
Merged

add note under datetime in schema reference #5801

merged 6 commits into from
May 2, 2024

Conversation

grpatel
Copy link
Contributor

@grpatel grpatel commented Apr 3, 2024

Fixes #5799

@grpatel grpatel linked an issue Apr 3, 2024 that may be closed by this pull request
Document lack of support for zero dates in MySQL #5799
Closed
@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 4:57pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

nikolasburk
nikolasburk previously requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks Grishma! just want small change please to write "Prisma ORM" instead of "we"

content/200-orm/050-overview/500-databases/400-mysql.mdx Outdated Show resolved Hide resolved
@janpio
Copy link
Contributor

janpio commented Apr 4, 2024

(Also see my comments in Slack, please)

@grpatel
Copy link
Contributor Author

grpatel commented Apr 4, 2024

(Also see my comments in Slack, please)

added mysql docs link and zero datetime (0000-00-00 00:00:00) here: 7d4a7cb

created task to expand on this content in the future

@jharrell jharrell requested a review from nikolasburk May 1, 2024 16:56
@jharrell jharrell dismissed nikolasburk’s stale review May 1, 2024 16:56

dimiss stale review

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented May 1, 2024 •
edited
Loading

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 20ab606
Status: ✅  Deploy successful!
Preview URL: https://c60b603a.docs-51g.pages.dev
Branch Preview URL: https://5799-document-lack-of-suppor.docs-51g.pages.dev

View logs

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Absolute URL check

No absolute URLs to prisma.io/docs found.

@prisma prisma deleted a comment from github-actions bot May 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

original preview
content/200-orm/050-overview/500-databases/400-mysql.mdx content/200-orm/050-overview/500-databases/400-mysql.mdx
content/200-orm/500-reference/100-prisma-schema-reference.mdx content/200-orm/500-reference/100-prisma-schema-reference.mdx

@jharrell jharrell merged commit af23406 into main May 2, 2024
11 of 13 checks passed
@jharrell jharrell deleted the 5799-document-lack-of-support-for-zero-dates-in-mysql branch May 2, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharrell jharrell jharrell approved these changes

@janpio janpio Awaiting requested review from janpio

@nikolasburk nikolasburk Awaiting requested review from nikolasburk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document lack of support for zero dates in MySQL
4 participants
@grpatel @janpio @nikolasburk @jharrell