Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add docs for new recommendations (DA-1498) #6325

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: add docs for new recommendations (DA-1498) #6325

wants to merge 9 commits into from

Conversation

ankur-arch
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Absolute URL check

No absolute URLs to prisma.io/docs found.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

original preview
content/700-optimize/400-recommendations/400-repeated-query.mdx content/700-optimize/400-recommendations/400-repeated-query.mdx
content/700-optimize/400-recommendations/500-select-returning.mdx content/700-optimize/400-recommendations/500-select-returning.mdx
content/700-optimize/300-recordings.mdx content/700-optimize/300-recordings.mdx

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2024 •
edited
Loading

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4527fcb
Status: ✅  Deploy successful!
Preview URL: https://d2508cd3.docs-51g.pages.dev
Branch Preview URL: https://da-1498.docs-51g.pages.dev

View logs

nikolasburk
nikolasburk reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I've left a few small/comments and suggestions.

content/700-optimize/400-recommendations/400-repeated-query.mdx Outdated Show resolved Hide resolved
content/700-optimize/300-recordings.mdx Outdated Show resolved Hide resolved
content/700-optimize/400-recommendations/500-select-returning.mdx Show resolved Hide resolved
content/700-optimize/400-recommendations/500-select-returning.mdx Outdated Show resolved Hide resolved
@ankur-arch ankur-arch self-assigned this Oct 9, 2024
nikolasburk
nikolasburk previously approved these changes Oct 9, 2024
View reviewed changes
mhessdev
mhessdev previously approved these changes Oct 9, 2024
View reviewed changes
@ankur-arch ankur-arch dismissed stale reviews from mhessdev and nikolasburk via 4527fcb October 10, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolasburk nikolasburk nikolasburk left review comments

@mhessdev mhessdev mhessdev left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ankur-arch ankur-arch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankur-arch @nikolasburk @mhessdev