-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cockroachdb: add v23.1.13 #76
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolg42
changed the title
cockroachdb: Update Dockerfile and pin version to v23.1.13
cockroachdb: Update Dockerfile and add v23.1.13
Dec 15, 2023
Jolg42
changed the title
cockroachdb: Update Dockerfile and add v23.1.13
cockroachdb: add v23.1.13
Dec 15, 2023
Weakky
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Note: I will merge this after the release |
Jolg42
added a commit
that referenced
this pull request
Jan 10, 2024
I forgot to edit this file in the previous PR #76 I also cleaned it up.
Note: unrelated to this PR, cross compilation images failed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes https://www.cockroachlabs.com/docs/releases/v23.1
It should appear once merged at https://hub.docker.com/r/prismagraphql/cockroachdb-custom/tags
I want to be able to test against a pinned version. I think it's a better approach.
Because our cockroachdb image for
23.1
was updated "recently" but it's not instantly obvious what's the exact version used.The update resulted in Renovate picking up the new docker sha and with an automated PR
prisma/prisma-engines#4504
I want to change the version in that PR for
23.1.13
once this PR is merged here.