fix: Fix esm, migrate to tsup #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ESM build: - ensures that import for `@prisma/client/extension` has `.js` extension in the source file. - removes `debug`: in plays very badly with ESM/non-node environments. If we'll need logging library in the future, we should pick something more ESM and VanillaJS friendly. - Adds test to ensure both CJS and ESM can be loaded without errors. Additionally, remvoes a whole bunch of custom scripts and config files for building the module in favor of `tsup`. Close #9
SevInf
force-pushed
the
fix/esm-build
branch
from
6d5f7b7
to
200e76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ESM build:
@prisma/client/extensionhas.jsextensionin the source file.
debug: in plays very badly with ESM/non-node environments.If we'll need logging library in the future, we should pick something
more ESM and VanillaJS friendly.
Additionally, remvoes a whole bunch of custom scripts and config files
for building the module in favor of
tsup.Close #9