fix: noop update from selectors should work #4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4092 will not alter performanceComparing Summary
|
Weakky
commented
Jul 31, 2023
Comment on lines
+67
to
+73
| Self::UpdateRecord(UpdateRecord::WithExplicitSelection(ur)) => { | ||
| ur.selected_fields.is_superset_of(field_selection) | ||
| } | ||
| Self::UpdateRecord(UpdateRecord::WithImplicitSelection(ur)) => { | ||
| ur.selected_fields().is_superset_of(field_selection) | ||
| } | ||
| Self::UpdateRecord(UpdateRecord::WithoutSelection(_)) => returns_id, |
There was a problem hiding this comment.
This is a bit out of scope for this PR.
This method, WriteQuery::returns, is used to compute reload nodes by checking whether a node's field selection fulfills its children data dependencies. It had not been updated after making UpdateRecord nodes return an arbitrary selection set. This means that some reload nodes might've not been added in cases it's needed.
Weakky
commented
Jul 31, 2023
Comment on lines
+29
to
+31
| let filter = build_update_one_filter(record_filter); | ||
|
|
||
| return get_single_record(conn, model, &filter, &selected_fields, &[], ctx).await; |
There was a problem hiding this comment.
The actual fix. The filter generated for the read in the case of a noop update now takes into account the whole RecordFilter, thus rendering a filter for selectors too if any are present.
miguelff
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #4084. Fixes a regression for 1-1 update when relationMode=prisma.
The PR fixes two things:
relationMode=prisma, we read the record to update before doing the actual update to compute whether some referential actions will need to be added to the graph. When doing this additional read, we pass the read ids down to the update operation so that we save reading the ids again when the connector does not supportUpdateReturning. These ids are passed asRecordFilter.selectors. However, the selectors were not considered when doing a simple read for a noop update. Therefore, the update node wasn't returning the correct ids, leading to failed operations later on.WriteArgs::returnsis now updated to take into account the fact that update nodes can now return more than just the primary identifier of a model. While we haven't noticed any bug, it could've resulted in missing reload nodes when the child of a node is requesting data dependencies that aren't fulfilled by the parent's selection set.See https://prisma-company.slack.com/archives/C058VM009HT/p1690562457715389