Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver-adapters: Rename ColumnType::Char to Character #4402

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Nov 1, 2023

To avoid confusion with SQL's CHAR type that is a fixed-length string,
not single character.

To avoid confusion with SQL's CHAR type that is a fixed-length string,
not single character.
@SevInf SevInf requested a review from a team as a code owner November 1, 2023 08:21
@SevInf SevInf added this to the 5.6.0 milestone Nov 1, 2023
@SevInf SevInf requested review from Weakky and Druue and removed request for a team November 1, 2023 08:21
Copy link

codspeed-hq bot commented Nov 1, 2023

CodSpeed Performance Report

Merging #4402 will degrade performances by 5.47%

Comparing refactor/char (ce95861) with main (49b44c5)

Summary

❌ 1 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main refactor/char Change
large_read 7.2 ms 7.6 ms -5.47%

@SevInf SevInf merged commit 82dc77d into main Nov 1, 2023
27 of 32 checks passed
@SevInf SevInf deleted the refactor/char branch November 1, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants