Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use fractionals in PS Datetimes #4426

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix: Use fractionals in PS Datetimes #4426

merged 2 commits into from
Nov 8, 2023

Conversation

miguelff
Copy link
Contributor

@miguelff miguelff commented Nov 8, 2023

Fixes a test failing for PS, that was flakey (when the fractional crossed the second boundary) but legitimate identifying a bug.

@miguelff miguelff requested a review from a team as a code owner November 8, 2023 10:54
@miguelff miguelff requested review from jkomyno and Druue and removed request for a team November 8, 2023 10:54
@miguelff miguelff self-assigned this Nov 8, 2023
@miguelff miguelff added this to the 5.6.0 milestone Nov 8, 2023
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 8, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #4426 will not alter performance

Comparing integration/ps-datetime-fidelity (e596b1a) with main (e62f312)

Summary

✅ 11 untouched benchmarks

@miguelff miguelff mentioned this pull request Nov 8, 2023
Merged
@miguelff miguelff merged commit 2963919 into main Nov 8, 2023
34 of 38 checks passed
@miguelff miguelff deleted the integration/ps-datetime-fidelity branch November 8, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@jkomyno jkomyno Awaiting requested review from jkomyno jkomyno was automatically assigned from prisma/orm-rust-maintain

@Druue Druue Awaiting requested review from Druue Druue was automatically assigned from prisma/orm-rust-maintain

Assignees

@miguelff miguelff

Labels
None yet
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelff @Jolg42