Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fix MySQL 5.7 definition in docker-compose #4430

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Nov 9, 2023

Before this PR, running

docker compose -f docker-compose.yml up --remove-orphans mysql-5-7

resulted in the mysql-5-7 container continuously restarting with the following error:

prisma-engines-mysql-5-7-1  | 2023-11-09 15:58:30+00:00 [ERROR] [Entrypoint]: MYSQL_USER="root", MYSQL_USER and MYSQL_PASSWORD are for configuring a regular user and cannot be used for the root user
prisma-engines-mysql-5-7-1  |     Remove MYSQL_USER="root" and use one of the following to control the root user password:
prisma-engines-mysql-5-7-1  |     - MYSQL_ROOT_PASSWORD
prisma-engines-mysql-5-7-1  |     - MYSQL_ALLOW_EMPTY_PASSWORD
prisma-engines-mysql-5-7-1  |     - MYSQL_RANDOM_ROOT_PASSWORD
prisma-engines-mysql-5-7-1 exited with code 1

This caused Schema Engine tests targeting MySQL 5.7 to fail in main.

Removing the MYSQL_USER: root env var from the docker-compose definition fixed the problem locally. Let's run this on the CI.

@jkomyno jkomyno requested a review from Druue November 9, 2023 16:04
@jkomyno jkomyno marked this pull request as ready for review November 9, 2023 16:04
@jkomyno jkomyno requested a review from a team as a code owner November 9, 2023 16:04
@jkomyno jkomyno requested review from miguelff and removed request for a team and miguelff November 9, 2023 16:04
@Druue Druue added this to the 5.6.0 milestone Nov 9, 2023
@janpio
Copy link
Contributor

janpio commented Nov 9, 2023

If this works and is needed, make sure to check all other @prisma repos - we probably copy/pasted that to other places.

@jkomyno
Copy link
Contributor Author

jkomyno commented Nov 9, 2023

If this works and is needed, make sure to check all other @prisma repos - we probably copy/pasted that to other places.

Neither prisma/prisma nor prisma/ecosystem-tests use mysql:5.7, so I think we don't need to modify any other repo.

Copy link

codspeed-hq bot commented Nov 9, 2023

CodSpeed Performance Report

Merging #4430 will not alter performance

Comparing fix/mysql-5.7 (45fefed) with main (2963919)

Summary

✅ 11 untouched benchmarks

@Druue Druue merged commit f9e46ef into main Nov 9, 2023
54 of 58 checks passed
@Druue Druue deleted the fix/mysql-5.7 branch November 9, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants