Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename prisma-models to query-structure #4458

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Weakky
Copy link
Contributor

@Weakky Weakky commented Nov 16, 2023

Overview

Preparatory core refactoring to support joins through FieldSelection and not ReadQuery.

  • Moves Filter, QueryArguments, and *Compare interfaces to query-structure
  • Renames prisma-models to query-structure (naming up to debate) (rename needed to better reflect the larger scope that prisma-models now encompasses)

Goal:

  • Enable abstracting aggregation selections in SelectedField, thus removing the need for RelAggregationSelection (still defined in query_connector).
  • Enable abstracting relation selections (for joins) in SelectedField

FWIW, uncle gippity suggested the following other namings for the new query-structure crate:

  • query-framework: Suggesting a foundational set of tools and abstractions for query construction.
  • query-schema: Reflecting the definition and organization of query elements.
  • query-architecture: Indicating a comprehensive design or blueprint for query elements.
  • query-composition: Highlighting the arrangement and combination of query components.
  • query-blueprint: Conveying the idea of a detailed plan or model for query construction.
  • query-fabric: Suggesting the underlying fabric or structure of queries.~
  • query-skeleton: Indicating the basic structure or framework of a query.
  • query-template: Implies a predefined structure or pattern for query elements.

@Weakky Weakky requested a review from a team as a code owner November 16, 2023 14:11
@Weakky Weakky requested review from miguelff and jkomyno and removed request for a team November 16, 2023 14:11
@Weakky Weakky marked this pull request as draft November 16, 2023 14:11
Copy link

codspeed-hq bot commented Nov 16, 2023

CodSpeed Performance Report

Merging #4458 will not alter performance

Comparing chore/join-prepation-work (739ba4d) with main (0a59e97)

Summary

✅ 11 untouched benchmarks

@miguelff
Copy link
Contributor

query-structure is a better name than anything GPT has imagined.

@Weakky
Copy link
Contributor Author

Weakky commented Nov 16, 2023

query-structure is in fact another suggestion from uncle gippity 😆

@Weakky Weakky marked this pull request as ready for review November 27, 2023 14:20
@Weakky Weakky added this to the 5.7.0 milestone Nov 27, 2023
@Weakky Weakky merged commit 01aad9b into main Nov 27, 2023
58 checks passed
@Weakky Weakky deleted the chore/join-prepation-work branch November 27, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants