Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crdb sql-introspection tests and pin docker image versions #4490

Closed
wants to merge 2 commits into from

Conversation

miguelff
Copy link
Contributor

@miguelff miguelff requested a review from a team as a code owner November 22, 2023 16:31
@miguelff miguelff requested review from jkomyno and Druue and removed request for a team November 22, 2023 16:31
@miguelff
Copy link
Contributor Author

Putting this on hold, there are 3 new tests failing having to do with sequences. I will keep working on this task.

Copy link

codspeed-hq bot commented Nov 22, 2023

CodSpeed Performance Report

Merging #4490 will improve performances by 5.78%

Comparing fix-crdb-tests (59c797b) with main (2c867f4)

Summary

⚡ 1 improvements
✅ 10 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-crdb-tests Change
large_read 7.6 ms 7.2 ms +5.78%

@janpio
Copy link
Contributor

janpio commented Nov 27, 2023

@miguelff conflict in docker sha now

@miguelff
Copy link
Contributor Author

This is not a priority after tests becoming stable again by pinning the previous versions of CRDB

@miguelff miguelff closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants