-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(qe): make UpdateRecord::WithSelection
nodes return RecordSelection
#4508
Merged
aqrln
merged 10 commits into
main
from
fix-qe-regression-in-queries-with-update-returning
Dec 4, 2023
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2107881
fix(qe): regression in queries with update returning
aqrln 767351c
Show selection in update nodes in graphviz visualization
aqrln e25151c
Project node's selection result into dependent's field selection
aqrln 315f46a
Remove unnecessary type annotation
aqrln b5584df
Revert "Remove unnecessary type annotation"
aqrln 94c60ce
Revert "Project node's selection result into dependent's field select…
aqrln 6f7607a
Make `UpdateRecord::WithSelection` always have name
aqrln 4a76e4e
Add graphviz to the dev shell
aqrln afcae32
Use an empty string instead of a dummy name
aqrln 27b325d
Add comment and rename test
aqrln File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ in | |
nodejs.pkgs.pnpm | ||
|
||
jq | ||
graphviz | ||
wasm-bindgen-cli | ||
wasm-pack | ||
]; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
query-engine/connector-test-kit-rs/query-engine-tests/tests/new/regressions/prisma_21182.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
use query_engine_tests::*; | ||
|
||
/// Regression test for https://github.com/prisma/prisma/issues/21182 | ||
#[test_suite(schema(schema))] | ||
mod regression { | ||
use indoc::indoc; | ||
|
||
fn schema() -> String { | ||
indoc! {r#" | ||
model User { | ||
#id(id, Int, @id) | ||
email String @unique | ||
name String? | ||
roleId Int | ||
role Role @relation(fields: [roleId], references: [id]) | ||
} | ||
model Role { | ||
#id(id, Int, @id) | ||
name String | ||
users User[] | ||
tagId Int? | ||
tag Tag? @relation(fields: [tagId], references: [id]) | ||
} | ||
model Tag { | ||
#id(id, Int, @id) | ||
name String | ||
roles Role[] | ||
} | ||
"#} | ||
.to_owned() | ||
} | ||
|
||
#[connector_test] | ||
async fn query_with_normalized_dependencies(runner: Runner) -> TestResult<()> { | ||
run_query!( | ||
runner, | ||
indoc! {r#" | ||
mutation { | ||
createOneUser ( | ||
data: { | ||
id: 1, | ||
email: "[email protected]", | ||
role: { | ||
create: { | ||
id: 1, | ||
name: "ADMIN", | ||
tag: { | ||
create: { | ||
id: 1, | ||
name: "cs" | ||
} | ||
} | ||
} | ||
} | ||
} | ||
) { | ||
id, | ||
email, | ||
roleId | ||
} | ||
} | ||
"#} | ||
); | ||
|
||
run_query!( | ||
runner, | ||
indoc! {r#" | ||
mutation { | ||
updateOneUser( | ||
where: { | ||
email: "[email protected]", | ||
}, | ||
data: { | ||
role: { | ||
update: { | ||
data: { | ||
tag: { | ||
disconnect: true | ||
} | ||
} | ||
} | ||
} | ||
} | ||
) { | ||
id, | ||
email, | ||
roleId | ||
} | ||
} | ||
"#} | ||
); | ||
|
||
Ok(()) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
to_owned()
becausefield.name
is already an owned string, and we don't need it anymore here so we can just move it without cloning.