fix(schema-engine): Ensure WS migrations can use shadow database #5021
+46
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previousy, when creating shadow DB connection over websocket, we connected to the same DB which broke in every `migrate` case except the one that starts with clean migration history. This PR ensures it works normally. Implementation is quite cursed though: for WS we now allow to override db name via `dbname` query string parameter. If set, we ignore `dbname` that we got from migration server and use provided DB with the same username and password. Shadow DB then uses this query string parameter to specify the url. Close ORM-325
WASM Query Engine file Size
|
jkomyno
approved these changes
Oct 17, 2024
SevInf
added a commit
that referenced
this pull request
Oct 17, 2024
* fix(schema-engine): Ensure WS migrations can use shadow database Previousy, when creating shadow DB connection over websocket, we connected to the same DB which broke in every `migrate` case except the one that starts with clean migration history. This PR ensures it works normally. Implementation is quite cursed though: for WS we now allow to override db name via `dbname` query string parameter. If set, we ignore `dbname` that we got from migration server and use provided DB with the same username and password. Shadow DB then uses this query string parameter to specify the url. Close ORM-325 * Clippy + rustfmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previousy, when creating shadow DB connection over websocket, we
connected to the same DB which broke in every
migratecase except theone that starts with clean migration history.
This PR ensures it works normally. Implementation is quite cursed
though: for WS we now allow to override db name via
dbnamequerystring parameter. If set, we ignore
dbnamethat we got from migrationserver and use provided DB with the same username and password. Shadow
DB then uses this query string parameter to specify the url.
Close ORM-325