Repository Initialization #1
Conversation
0xjei
force-pushed
the
chore/boilerplate
branch
from
62e22d0
to
e62ea1c
Compare
0xjei
force-pushed
the
chore/boilerplate
branch
from
e62ea1c
to
93ea82e
Compare
Basic Github Action to enforce style and test on pull requests
0xjei
force-pushed
the
chore/boilerplate
branch
from
e99388c
to
79b6c40
Compare
0xjei
force-pushed
the
chore/boilerplate
branch
from
84c8352
to
45a509f
Compare
| @@ -0,0 +1,61 @@ | |||
| { | |||
| "name": "excubiae", | |||
There was a problem hiding this comment.
there's no need for a version on the root package.json since is a monorepo.
| @@ -0,0 +1,10 @@ | |||
| # core | |||
| DEFAULT_NETWORK=hardhat | |||
There was a problem hiding this comment.
where's this used? iirc in hardhat the hardhat network is the default already
There was a problem hiding this comment.
this can be helpful for custom default networks (running nodes different from current hardhat environment / network).
There was a problem hiding this comment.
oh right thought it'd be more convenient to pass --network $NETWORK to the command so you don't have to switch env var but this works too
| @@ -0,0 +1,30 @@ | |||
| { | |||
There was a problem hiding this comment.
this makes easy to release just the contracts and avoid carrying on a huge bundle of configs & other dev env packages. This is the default project structure when using hardhat.
The idea here is to get the Excubiae project up and running with a basic boilerplate to test the configs. As a general rule, we look to the best-maintained and best-configured TS projects in PSE as guidance. Some examples include semaphore and zk-kit.
The
contractspackage supports bothhardhatandfoundry. Therefore, thecontractspackage needs to be renamed for the necessaryremappings, and so some configs have been moved around to minimise duplication.