Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: document magic numbers in bytes_length #304

Merged
merged 6 commits into from
Mar 29, 2024
Merged

chore: document magic numbers in bytes_length #304

merged 6 commits into from
Mar 29, 2024

Conversation

duguorong009
Copy link

@duguorong009 duguorong009 commented Mar 28, 2024 •
edited
Loading

Description

  • comment the constants used when determining the bytes length of ProvingKey & VerifyingKey

Related issues

Changes

  • correct the 10 as 6 in VerifyingKey::bytes_length
  • comment the constant(6) in VerifyingKey::bytes_length
  • comment the constant(12) in ProvingKey::bytes_length

@duguorong009 duguorong009 self-assigned this Mar 29, 2024
@duguorong009 duguorong009 marked this pull request as ready for review March 29, 2024 05:37
@duguorong009 duguorong009 requested review from ed255 and CPerezz March 29, 2024 05:37
CPerezz
CPerezz approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ed255
ed255 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@duguorong009 duguorong009 merged commit 720ba51 into main Mar 29, 2024
16 checks passed
@duguorong009 duguorong009 deleted the gr@comment-magic-numbers branch March 29, 2024 09:57
@duguorong009 duguorong009 mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPerezz CPerezz CPerezz approved these changes

@ed255 ed255 ed255 approved these changes

Assignees

@duguorong009 duguorong009

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document magic number in ProvingKey
3 participants
@duguorong009 @ed255 @CPerezz