fix: not allow input negative values for votes

privacy-scaling-explorations · Aug 30, 2024 · 678260b · 678260b
1 parent 0b6f148
commit 678260b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/interface/src/features/ballot/components/AllocationInput.tsx b/packages/interface/src/features/ballot/components/AllocationInput.tsx
@@ -29,6 +29,7 @@ export const AllocationInput = ({
         {...props}
         render={({ field }) => (
           <NumericFormat
+            allowNegative={false}
             aria-label="allocation-input"
             customInput={Input}
             error={props.error}
@@ -38,7 +39,7 @@ export const AllocationInput = ({
             defaultValue={props.defaultValue as string}
             disabled={props.disabled}
             isAllowed={({ floatValue }) =>
-              votingMaxProject !== undefined ? (floatValue ?? 0) <= votingMaxProject : true
+              votingMaxProject !== undefined ? (floatValue ?? 0) <= votingMaxProject : (floatValue ?? 0) >= 0
             }
             thousandSeparator=","
             onBlur={onBlur}

diff --git a/packages/interface/src/features/projects/components/VotingWidget.tsx b/packages/interface/src/features/projects/components/VotingWidget.tsx
@@ -72,12 +72,13 @@ export const VotingWidget = ({ projectId }: IVotingWidgetProps): JSX.Element =>
 
       <div className="flex items-center justify-center gap-5 rounded-xl border border-gray-200 p-5 dark:border-gray-800">
         <NumericFormat
+          allowNegative={false}
           aria-label="allocation-input"
           autoComplete="off"
           className="dark:bg-lightBlack w-auto dark:text-white"
           customInput={Input}
           defaultValue={amount}
-          isAllowed={({ floatValue }) => (floatValue ?? 0) <= initialVoiceCredits}
+          isAllowed={({ floatValue }) => (floatValue ?? 0) <= initialVoiceCredits && (floatValue ?? 0) >= 0}
           thousandSeparator=","
           onChange={handleInput}
         />